search

circleci / rollcage

A Clojure client for Rollbar
Eclipse Public License 1.0
50 stars 28 forks source link

Allow an additional handler to be specified for uncaught exceptions. #30

Closed technomancy closed 6 years ago

technomancy commented 6 years ago

This is needed to allow the new version of rollcage to be used here: https://github.com/circleci/service-utils/pull/110

codecov[bot] commented 6 years ago

Codecov Report

Merging #30 into master will decrease coverage by 0.64%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   97.31%   96.66%   -0.65%     
==========================================
  Files           2        2              
  Lines         149      150       +1     
  Branches        3        3              
==========================================
  Hits          145      145              
- Misses          1        2       +1     
  Partials        3        3
Impacted Files Coverage Δ
src/circleci/rollcage/core.clj 96.45% <0%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88effe9...cd1a849. Read the comment docs.

technomancy commented 6 years ago

Does that look better?

technomancy commented 6 years ago

Thanks.

JustinC474 commented 6 years ago

@technomancy should we add a test for the failure case? seems simple enough and this repo is almost at 100% coverage