circleci / rollcage

A Clojure client for Rollbar
Eclipse Public License 1.0
51 stars 28 forks source link

Feature request: person tracking #53

Open skuro opened 3 years ago

skuro commented 3 years ago

In order to use the person tracking Rollbar feature, a person key is sent along with the payload. There's currently a TODO on it in the codebase on the subject.

skuro commented 3 years ago

My proposal is to add an optional argument to make-rollbar so that it can actually propagate the person data. I'll try to come up with a rough PR to explain my concept a bit better, but something along the lines of

(defn notify
  "Report an exception to Rollbar."
  ([^String level client ^Throwable exception]
   (notify level client exception {}))
  ([^String level {:keys [result-fn send-fn block-fields] :as client} ^Throwable exception {:keys [url params person]}] ;; <-- here!
   ..same as before..))