circlefin / verite

https://verite.id
MIT License
137 stars 59 forks source link

add JWT sample #500

Closed kimdhamilton closed 1 year ago

kimdhamilton commented 1 year ago

Per previous discussion, here's an updated example of the decoded intermediate form and corresponding JWT

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
verity-demo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 3:40AM (UTC)
verity-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 3:40AM (UTC)
bumblefudge commented 1 year ago

LGTM, except maybe while we're here we should make some changes to the non-normative text to help the less-initiated reader, for instance, instead of:

The following represents the intermediate did-jwt-vc decoded form of a JWT-encoded verifiable credential:

Maybe it should read

The following represents the "intermediate" did-jwt-vc decoded form of a JWT-encoded verifiable credential, i.e., the form with mandatory JWT payload properties duplicated and translated into their VC data model equivalents for interoperability with non-JWT VCs:

kimdhamilton commented 1 year ago

The following represents the "intermediate" did-jwt-vc decoded form of a JWT-encoded verifiable credential, i.e., the form with mandatory JWT payload properties duplicated and translated into their VC data model equivalents for interoperability with non-JWT VCs:

yes, brilliant. Included in latest commit