circlingthesun / angular-foundation-6

Foundation 6 directives for Angular 1.5+
http://circlingthesun.github.io/angular-foundation-6/
Other
95 stars 50 forks source link

Tabs not working anymore with latest foundation release. #43

Closed ro8in closed 7 years ago

ro8in commented 7 years ago

With Foundation 6.3.0 the TABS are not working anymore. Tabs are showing, but the content of the tab is not.

Had to revert back to the CSS from 6.2.4

circlingthesun commented 7 years ago

It has not been tested with 6.3 yet.

MrNuTruT commented 7 years ago

yes i have the same problem

mamsoudi commented 7 years ago

@circlingthesun The problem is that foundation uses the CSS code below or should I say aria-hidden="false" to check if a tab's content should be seen or not in the latest version! But in v6.2.x it used .is-active class along with .tab-panel to show tabs content! I donno if this is a good approach or not or why did they do this. I liked the old approach of doing this.

.tabs-panel[aria-hidden="false"] {
    display: block;
}
circlingthesun commented 7 years ago

@mamos98, thanks for pointing that out. This project aims to be compatible with foundation for sites without external css. So the code will have to be updated. Personally, I see no real benefit in moving to 6.3.0 at this stage. I'm not opposed to upgrading, I just don't have the time right now. I'm open to PRs though :)

mamsoudi commented 7 years ago

@christopherthielen I would love to. But I also agree that most of the people are still using the version 6.2.x. I downgraded to 6.2.x myself. I'll work on it once I get the chance!

circlingthesun commented 7 years ago

Fixed in #59