circlingthesun / angular-foundation-6

Foundation 6 directives for Angular 1.5+
http://circlingthesun.github.io/angular-foundation-6/
Other
95 stars 50 forks source link

Pagination is buggy looking with latest version of Foundation + AngularJS #86

Closed TylerOrtiz closed 5 years ago

TylerOrtiz commented 5 years ago

Found an issue with pagination where the First / Last links get an additional arrow selector since the anchor tag should only exist for "clickable" links in the pagination.

This means that the "Previous" and "Next" buttons will be encapsulated in anchor tags based on the template.

See this Plunkr for reference: Plunkr

  <ul class="pagination" role="navigation" aria-label="Pagination">
        <li ng-repeat="page in pages"
            ng-class="{
                'pagination-previous': $first,
                'pagination-next': $last,
                'current': page.active,
                'disabled': page.disabled
            }">
            <a ng-if="!page.active" ng-click="selectPage(page.number)">{{page.text}}</a>
            <span ng-if="page.active">{{page.text}}</span>
        </li>
    </ul>

The anchor tag shows even if the element is disabled (which is not right).

circlingthesun commented 5 years ago

Hi Tyler,

At this stage I'm no longer actively maintaining this project. If you'd like to make a PR, I'd be happy to have a look at it though.

Regards Rickert