circonus-labs / reconnoiter

Large-scale Monitoring and Trend Analysis System
Other
245 stars 62 forks source link

CIRC-9495 - fix handling of tags that are too long #826

Closed RobBoeckermann closed 1 year ago

RobBoeckermann commented 1 year ago

noit_metric_tagset_builder_add_many needs access to tag.total_size to correctly iterate through tagstr.

this fixes a bug where, when a tagnm was toolong the total_size was not being set and would result in an overflow when trying to subtract an unknown value from the size_t tagstr_len which is unsigned.

add test for tag pairs that are too long.

in the test file, I made Matches a structure definition to prevent merge conflicts when I add the implicit tag testing that uses the same struct.