added omnibus test - Githubissues

circstat / pycircstat

Toolbox for circular statistics with Python

MIT License

157 stars 42 forks source link

added omnibus test #22

Closed philippberens closed 9 years ago

philippberens commented 9 years ago

i added an additional test and ran into a few questions

do we want tests to operate on arrays of arbirtrary dimensions? to me that feel weird but apparently this is how other tests in scipy are implemented. to me it feels most natural to request 1D vectors or to ravel the array if this is not the case. if we decide this way, we need to take care of the axis argument in the two functions; if not the testing functions need to be fixed to account for that.
could somebody look the functions over for coding style improvements or other obvious things?
i added a utils file, because i didn't know were to put stuff for conversion from angular to radians and back

coveralls commented 9 years ago

Coverage increased (+0.21%) when pulling 806f0200db148dbdb736f5e8f48eafe68f521e91 on philippberens:master into 362c87c3f6e22f0f1468677f11e2a245222aa17a on circstat:master.

fabiansinz commented 9 years ago

Concerning the dimensions, I think we need to keep two things in mind:

if we want to make everything compatible with pandas as well, then the arrays will be 1d naturally
on the other hand, however it would be nice to make things compatible with scipy as well, i.e. offer tests along arbitrary dimensions

I think we can accomplish both. Therefore, I am in favor of implementing the axis functionality. But you guys might have different opinions.

philippberens commented 9 years ago

i fixed the bug already, but i am implementing another test and will upload everything togeter

philippberens commented 9 years ago

I think for making the tests compatible with running along arbitrary dimensions, I need a bit of help. Right now this functionality isn't properly taken care of

tomwallis commented 9 years ago

Are we going to run into trouble with nosetests having a file in the main toolbox called tests.py? My understanding is that nosetests will try to run anything called tests, which will result in problems because these functions don't assert anything.

On the other hand maybe this is just a simple case of pointing nosetests to the correct directory for the tests.

fabiansinz commented 9 years ago

I think I could implement something to make arbitrary dimensions easier. I would basically temporarily permute the array such that the test is computed along the zeros dimension and then flip it back. I have to think a little bit about it.

coveralls commented 9 years ago

Coverage increased (+0.68%) when pulling a27d81f8528861880b2760aebeea73917d8954c7 on philippberens:master into 362c87c3f6e22f0f1468677f11e2a245222aa17a on circstat:master.