Closed fabiansinz closed 9 years ago
Am I correct in thinking this is ready to be merged? The failure seems to be coveralls coverage rather than travis.
It's ready. I think one of the reasons why coverage decreased is that I have a few abstract methods that throw and NotImplemented error. In theory I should test whether this error is actually thrown, but I don't ... On 03/23/2015 10:06 PM, Tom Wallis wrote:
Am I correct in thinking this is ready to be merged? The failure seems to be coveralls coverage rather than travis.
— Reply to this email directly or view it on GitHub https://github.com/circstat/pycircstat/pull/44#issuecomment-85197514.
Dr. Fabian Sinz contact info: http://goo.gl/o87zXC
Coverage decreased (-1.7%) to 90.01% when pulling b97df0b8a222923694158a731002a7bcc7a99ca1 on fabiansinz:master into 71115413ea7cf7132db58a24dc1b2f74bcd3651f on circstat:master.