circstat / pycircstat

Toolbox for circular statistics with Python
MIT License
157 stars 42 forks source link

Fix Kuiper test #49

Closed Azhag closed 7 years ago

Azhag commented 7 years ago

Heya!

Was trying to get Kuiper 2 sample test going, and saw a few mistakes which I fixed:

Thanks for the package, really useful!

cheers Loic

fabiansinz commented 7 years ago

Hey Loic,

thanks for contributing. We haven't had a pull request in a while and we need to update our .travis.yml for automated testing. Once that is fixed, I will ask you to update your pull request. Thanks!

Fabian

fabiansinz commented 7 years ago

Can you merge the latest updates and update you pull request? We fixed the travis file.

Azhag commented 7 years ago

Done! But I didn't check the unit tests and they fail now, I'll have a look and see if I introduced a bug.

fabiansinz commented 7 years ago

That'd be great. Thank you.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.341% when pulling b33d7b10b0497a23a8107474b4385baaeae9cbe1 on Azhag:master into 41878f98a8a403334e02cf8a7bbdee8a55375859 on circstat:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.341% when pulling b33d7b10b0497a23a8107474b4385baaeae9cbe1 on Azhag:master into 41878f98a8a403334e02cf8a7bbdee8a55375859 on circstat:master.

Azhag commented 7 years ago

Ok fixed it, actually your test was wrong, which my commit fixed :P

Made a correct test now, with an N that really isn't in the Kuiper Table.

Added a test to make sure that results with angles in [0, 2pi] work in [-pi, pi], as I wasn't sure if the library supported it :)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.341% when pulling a6b8138ee43fd10c0cf993b34e88c2b31be44855 on Azhag:master into 41878f98a8a403334e02cf8a7bbdee8a55375859 on circstat:master.

fabiansinz commented 7 years ago

Thank you!