circstat / pycircstat

Toolbox for circular statistics with Python
MIT License
157 stars 42 forks source link

Removal of scipy.misc aliases (e.g. comb) causes errors. #65

Closed adamltyson closed 4 years ago

adamltyson commented 5 years ago

Scipy 1.3.0 has removed the deprecated aliases to a number of functions (e.g. scipy.misc.comb) which causes problems in e.g. https://github.com/circstat/pycircstat/blob/648ff7c8f0db08bb567097918269aba37cd7a802/pycircstat/tests.py#L121-L123

This can be fixed by using e.g. scipy.special.comb or specifying scipy<=1.2.1 as a dependency.

adamltyson commented 5 years ago

Fixed in https://github.com/circstat/pycircstat/pull/66

ctw commented 4 years ago

I also just submitted #70 that fixes this issue (hadn't seen that this was already in a pull requests).

philippberens commented 4 years ago

thanks - did that