search

circuitdiagram / components

Library of components for Circuit Diagram.
https://www.circuit-diagram.org/components
GNU General Public License v2.0
66 stars 118 forks source link

Filters #305

Closed taruncousik closed 2 months ago

taruncousik commented 3 months ago

Low Pass, Band Pass, Band Stop, High Pass. Useful to have it as a block instead of designing them

MarioSanz commented 2 months ago

Hi there @taruncousik, I made a component for that, maybe you want to give some feedback on it. This is the band-stop type, but I made it configurable for the other types you mentioned, plus an additional option for switched-capacitor type Frequency-filter

@SamuelFisher Is there a pipeline to submit and review new components?

SamuelFisher commented 2 months ago

HI @MarioSanz, this looks great.

Is there a pipeline to submit and review new components?

If you raise a PR in this repo I will prioritise reviewing it. Reviewing is quite time consuming, it will make it a lot easier if you can check things like this in advance before raising a PR:

  1. Does it display correctly at different sizes/when resizing
  2. Does it display correctly when placed vertically (not only horizontally)
  3. Do the connection points (pins where other components and wires can connect to) align correctly, including for different sizes and vertical placement
SamuelFisher commented 2 months ago

Added in #312.