Use Opaleye adaptors - Githubissues

tomjaguarpaw commented 1 year ago

This is part of my ongoing quest to reduce the amount of Opaleye internals that Rel8 depends on.

htraverseP seems generally useful and worth including regardless, if you want Rel8 to play well with the ProductProfunctors ecosystem.
~htraversePType is Table-specific. I'm not sure which module it should go in.~ EDIT: I changed the implementation so this doesn't exist any more.

Important note: I'm about to land a fairly big refactoring to Opaleye.Internal.Values (https://github.com/tomjaguarpaw/haskell-opaleye/commit/a7384fde097f6abf66fce17abfb122b3f26a00bb) which will break Rel8 master but is compatible with Rel8 post this PR.

tomjaguarpaw commented 1 year ago

I intend to merge the above-mentioned change to Opaleye.Internal.Values at the weekend. Rel8 isn't compatible with that change, but after this PR it would be. Can you please let me how you'd like to proceed? I think this PR is a significant simplification regardless.

ocharles commented 1 year ago

Sorry for the silence @tomjaguarpaw - been off a bit recently but I'll try and take a look soon :+1:

ocharles commented 1 year ago

Update: I want to get https://github.com/circuithub/rel8/pull/194 in so CI can build this. Not sure why that's being fiddly, but that's the blocker atm.

circuithub / rel8

Use Opaleye adaptors #190