search

circuithub / rel8

Hey! Hey! Can u rel8?
https://rel8.readthedocs.io
Other
150 stars 38 forks source link

Release 1.5.0.0 #298

Closed ocharles closed 3 months ago

ocharles commented 7 months ago

Fixes #293 and #288.

ocharles commented 7 months ago

@shane-circuithub I see that at CircuitHub we're also running https://github.com/circuithub/rel8/pull/284. Shall we call that tested and also merge that into this release?

ocharles commented 7 months ago

I would also like to see this build with all outdated deps: https://packdeps.haskellers.com/feed?needle=rel8

ocharles commented 6 months ago

Ok, upstream deps aren't ready for 9.8, so the only outdated dep we need to address is Opaleye, which is already fixed in master. I think we're good to go!

shane-circuithub commented 5 months ago

Hey, I merged the outstanding PRs that we're using in CircuitHub so this is nearly good to go now (though assuming the changelog is autogenerated from the scriv stuff you might want to regenerate that now that those PRs are in). The only remaining issue is that ordered set aggregation functions won't quite work until this fix to Opaleye is in. It's your call whether we wait for that to merge before releasing or not.

shane-circuithub commented 5 months ago

Do note that the "aggregation" section of the cookbook is completely wrong though, it dates from the time we had an Apply interface for Aggregate, before the first release. It's even more wrong now with the changes made to aggregation in this release. Maybe we should fix that?

ocharles commented 5 months ago

@shane-circuithub sorry for the delayed reply! I don't see a need to release ASAP, so I think we should wait for the Opaleye changes to land first.

sir4ur0n commented 3 months ago

What is the status of the 1.5.0.0 release please? The latest comment suggests this is waiting for https://github.com/circuithub/rel8/pull/298 to be merged and released, however this PR is closed, not merged.

On my project, we are waiting for some features present on master but not in a released version (most notably, the loop function, equivalent of WITH RECURSIVE), so I would like to check this releasing PR is not in some sort of deadlock :grin:

ocharles commented 3 months ago

Unfortunately just waiting on me to find the time to get the release out! Thanks for the nudge, I'll try and give this some more time soon

sir4ur0n commented 3 months ago

Awesome, thank you! :pray: