Improve clientside validations

[sandrab]

Improve the clientside javascript validations:

• Allow underscores and dots in the username (GDrive document 7.5 point 6) *.
• The name field on the registrationform ('Bedrijfsnaam' or 'Volledige naam') now checks for a minimum of two characters. Cyclos however, wants at least three characters in the Name field.
• Do not allow decimals in the 'Aankoop saldo'. At the moment it is possible to enter an amount with a comma and two digits after the comma (for example 8,50). This should not be allowed.
• Fix the validation of phonenumbers:
  • Allow '+31' besides '0031' (the regex now contains \\+31, maybe this should simple be \+31?)
  • Allow '-' character in mobile numbers too, not just in landlines. Adjust the validation message accordingly. Also change the validationmessage of landline: '-' character ('koppelteken') is allowed.
  • Allow the '31' variant on landlines with a 4-digit 'netnummer' and a '-' character. Now, if you use a '-' character, the '31' variant only works on landlines with a 3-digit 'netnummer'. So now 003130-1234567 is allowed but 0031514-123456 is not. Both should be allowed. Note: leaving the '-' out, (for example 0031514123456) it is allowed already (and should stay allowed of course). Maybe use the default "phoneNL" and "mobileNL" methods from the jqueryvalidation library? (check https://github.com/jquery-validation/jquery-validation/blob/master/src/additional/phoneNL.js and https://github.com/jquery-validation/jquery-validation/blob/master/test/methods.js).
• Maybe use the "dateNL" method for the date of birth? Also, maybe the moment.min.js library used now to check if date of birth is a valid date could then be removed.
• The url fieldtype, used for the Website field, requires a protocol (http(s)://). This is not user friendly, so make the protocol optional and fallback to http:// when the user leaves the protocol out.
• Use default methods from the jqueryvalidation library that is in use as much as possible. Only use custom methods if there is a reason to do so and document why in the code comments.
• When you type an invalid password, the validation message is shown. But as soon as you move the cursor out of the password field, the message disappears. Investigate if this behaviour can be made the same as for the other fields: the message should stay as long as the value is not valid.

A note about the username validation: In Cyclos the regular expression used for usernames is `^[\w.]$` which means letters, numbers, underscores (\w) and dots (.). This means that the 'alphanumeric' method from the jqueryvalidation library can not be used for the clientside validation in this case, because it only allows letters, numbers and underscores (\w) and no dots. The regex for usernames in Cyclos can be found via Systeem > [Systeemconfiguratie] Configuraties > Default for Nederland: regex voor gebruikersnaam.

[sandrab]

Note: Solve #6 first.

[sandrab]

@rmvanarkel : the GDrive document (7.5 point 6) only asks to allow underscores in usernames. I found out that Cyclos also allows dots. So not only pietje_puk but also pietje.puk is a valid username in Cyclos. Do you agree that the registrationform validation then should allow for both as well?

[sandrab]

Discussed with Roder: allowing dots in username is fine.

[sandrab]

@rmvanarkel For the username field I see validation rules in Cyclos (global administration > System > Configurations > 'Global default'):

• Regular expression for login name: ^[\w.]*$
• Login name length: 2 to 16.

Do you know if/where Cyclos also configures the validation rules for the name field? See the second point of this github issue: Cyclos wants the name field to have at least 3 characters. I discovered this by chance, but I can not find this in the Cyclos configuration. I wonder if there are other validation rules for this field - if so, we can let the clientside validation follow the same rules.