Investigate flow when brokers or admins register new users

[sandrab]

When a broker or admin registers a new user directly in Cyclos, we must check if the procedure and flow are clear and as we would like them to be.

Notes:

• A user might be registered through the registration form, but also directly in Cyclos (by a broker or admin) or via the app. Do we need to cater for these different sources? For example, the registrationform contains a checkbox to accept the agreement(s). If a user is registered via another source than the form, he has not seen a checkbox like that. So, in those cases, we should not accept pending agreements while validating the user. Perhaps we might be able to use BasicUser - getRegisteredBy() to check if the user was created by the reg_form_admin user that is doing the create request when a user registers via the registrationform?
• Currently, activateUserCheckPayments does nothing when a user is validated that was registered by a broker (if usr.brokers the script stops). Is this correct? Should it check for the reg_form_admin user instead, so this also happens when admins register a user? When the script stops, it also means the user gets validated without checking whether the user paid their contribution and the user gets no transactions and no iDEAL userrecord. Is this the desired behaviour for users that get registered by brokers (and/or admins)? They might not have paid, but can still be an active user?

[sandrab]

Discussed with Roder that we will make two changes:

1. In the user operation script that is available for financial admins to validate a user in case of an alternative payment method (instead of iDEAL): add a new form field so the admin can indicate whether the user has accepted the agreements or not. Depending on the answer, alternativePaymentValidation will call utils.acceptAgreements() or not.
2. In the activateUserCheckPayment extension script: instead of doing nothing when the user was registered by a broker (if usr.brokers), just do all normal actions in this case, except calling utils.acceptAgreements().

This way, users registered directly in Cyclos by a broker never have their agreements accepted during validation - they can do so at first login.
For users registered direcly in Cyclos by an admin we assume an admin only does this when they are certain the user has accepted the agreements (and can prove this by a paper form), or the admin will use the alternative operation to validate the user in case of an alternative payment method and fill in the new formfield indicating agreements were accepted as 'No'.

Note: as part of this issue, please confirm that when the agreements are not accepted by a script, the user needs to accept them at first login indeed.

[sandrab]

Note we should use user.brokers instead of usr.brokers now usr is a wrapped DTO.

Confirmation: when the agreements are not accepted by a script, the user gets prompted to accept them after logging in, making it impossible to do anything else but either accept or log out.

[sandrab]

Reopened because we postponed deploying v1.1.2. Will be closed as soon as we deploy a new release to production.

[sandrab]

This issue is closed as part of the v1.2.0 release.