Remove maximum 'aankoop saldo' for particulieren

circuitnederland / registrationform

0 stars 0 forks source link

Remove maximum 'aankoop saldo' for particulieren #7

Closed sandrab closed 6 years ago

sandrab commented 6 years ago

(From GDrive document 7.5 point 4). Particulieren may now also buy the 'aankoop saldo' they want, without a maximum of 150 euro. So change the maximum for particulieren to the same as the maximum for bedrijven, that is 50.000.

Change this in the clientside validation in stro_form_validation.js.
(in Cyclos) Adjust the information-text in the Profilefield 'Aankoop_saldo'. This must be done manually in Cyclos prd as soon as this change is deployed there.

sandrab commented 6 years ago

I found a field 'Maximaal aankoop bedrag particulieren' (maxAankoopPart) in (test) Cyclos in the 'Molly configuration (keep safe)' (mollyConnect) record type. I don't see any use of maxAankoopPart in the 'mollie' library script or 'mollieWebhook' script. Can we somehow figure out whether this field is used somewhere in Cyclos? I suppose if this field is not used anywhere, we could remove it as part of this issue?

sandrab commented 6 years ago

Discussed with Roder:

the maxAankoopPart can go. We just renamed its' internal name in test Cyclos. As soon as we are completely sure it is not used anywhere, we could ask a Cyclos programmer to delete the field for us.
In register.php the maxAankoopPart is picked up from the mollie record in Cyclos. But actually it is not used (anymore) to create a maximum validation. So we can comment out the maxAankoopPart code.