Do not allow adding watchers with the same lowercase names

circus-tent / circus

A Process & Socket Manager built with zmq

http://circus.readthedocs.org/

Other

1.55k stars 258 forks source link

Do not allow adding watchers with the same lowercase names #1117

Closed biozz closed 4 years ago

biozz commented 4 years ago

add conversion to lowercase when checking for existing watcher
add test with two watchers foo and Foo, which should raise

Fixes #936

coveralls commented 4 years ago

Coverage remained the same at 62.97% when pulling 74f4c72b96ec97a87fa6d19f415d1b864828e64d on biozz:same-lowercase-name-watchers into 817216674293e60b85f645ffc5eaf13edd96dd44 on circus-tent:master.

coveralls commented 4 years ago

Coverage remained the same at ?% when pulling 12df4485ce8fc148e9f7f106fe2472428d110112 on biozz:same-lowercase-name-watchers into 95905cfa84b5171252032672512af42953e47104 on circus-tent:master.

k4nar commented 4 years ago

:+1:

Could you rebase on master to fix the py34 build?

biozz commented 4 years ago

OMG I screwed up this rebase hard... Will try to fix.

k4nar commented 4 years ago

At a glance, I would say that your fork's master was not up-to-date with the upstream :) .

biozz commented 4 years ago

@k4nar, I managed to fix it, could you please review it?