search

circus-tent / circus

A Process & Socket Manager built with zmq
http://circus.readthedocs.org/
Other
1.55k stars 257 forks source link

Change ConfigParser to RawConfig parser to avoid interpolation errors #1133

Closed biozz closed 4 years ago

biozz commented 4 years ago

Closes #1097.

The first implementation of time_format feature was done in #493, there was also a test, which checked that the feature works as expected.

But the test was designed in such a way that it used FileStream class and not the configuration file (like some other tests). Therefore the error described in #1097 wouldn't appear.

I changed ConfigParser to RawConfigParser, because it seems that interpolation feature, which is specific to ConfigParser, is not widely used and is not described in the documentation. So there is no reason to use ConfigParser.

I added time_format to example2.ini and did not add more tests, because if it not breaks and all of the other tests are working, then it should be OK.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.03%) to 63.942% when pulling 73aec1d725a906499482a5a2257c0a5a841b49a8 on biozz:b/1097_fix_percent_interpolation into 2bedab09145a4959ce02b93777dbffbce56edd8e on circus-tent:master.