Add windows-curses dependency for Windows

circus-tent / circus

A Process & Socket Manager built with zmq

http://circus.readthedocs.org/

Other

1.55k stars 258 forks source link

Add windows-curses dependency for Windows #1134

Open biozz opened 4 years ago

biozz commented 4 years ago

Closes #1100.

Disclaimer: I am using macOS and have difficulties setting up Windows environment to test this feature, so I would like to have some feedback from Windows users out there, pinging @ltalirz.

coveralls commented 4 years ago

Coverage decreased (-0.03%) to 63.875% when pulling 363e6672fbc6a050499be7707b22c4dfbc5c9cca on biozz:f/1100_add_windows_curses into 2bedab09145a4959ce02b93777dbffbce56edd8e on circus-tent:master.

ltalirz commented 4 years ago

@biozz Thanks for this - I don't use windows regularly either, and even if I did I think the best solution is to include a basic windows test in the CI.

In order to achieve this, I would suggest to:

move the CI from travis to github actions
add a test run on a windows runner, at least for one python version (also put one in for Macos, while we're at it)

I've had a look at the travis config of circus and it looks rather minimal. I'll have a quick go at a PR for 20 minutes - would you be happy to continue in case it turns out to take more effort?

biozz commented 4 years ago

@ltalirz yes, sure thing. I was also checking out travis docs and it has multi-os support including windows.

Personally I don't have any preference on the ci as long as it works and not too complicated to setup. Tagging @k4nar for an opinion.

ltalirz commented 4 years ago

I was also checking out travis docs and it has multi-os support including windows.

I see, wasn't even aware of that. We've been using Github actions since a couple of months and have been pretty happy with it, especially in terms of speed.

20 minutes was a bit too optimistic but looks like I'm done. Will make a PR.

k4nar commented 4 years ago

I tried to add a Windows CI via AppVeyor a few years ago, without any success. If you manage to do it that would be awesome!

ltalirz commented 4 years ago

If you manage to do it that would be awesome!

It's already done :-) However, the tests are still skipped on windows, i.e. it remains to be seen whether there are still tricks to be played. @biozz is kindly working on it

biozz commented 4 years ago

I am still trying to setup windows environment: virtualbox with windows server 2019 and things break where you don't expect. So that's why it takes quite a lot of time.

UPD: I couldn't get it to work, so for the time being this will have to wait for someone with windows experience to complete...