search

circus-tent / circus

A Process & Socket Manager built with zmq
http://circus.readthedocs.org/
Other
1.55k stars 257 forks source link

Fix failing resource watcher tests related to max_mem #1141

Closed biozz closed 4 years ago

biozz commented 4 years ago

Closes #1140.

I went through the test call-stack and found that the file which is used to test max memory is written before the the watcher is able to check the memory usage. Therefore the test fails.

The quickest solution is to add more chunks or increase chunk size so there will be enough time for the resource watcher to start and check system stats.

Playing with the chunk size is more of a workaround and not the actual fix, because the success rate of the test would highly depend on the machine, where tests are performed.

k4nar commented 4 years ago

Well, at least now it passes the CI :) . Maybe we could make the MacOS mandatory in Github Actions now?

biozz commented 4 years ago

I made MacOS test mandatory, but we might have to play around with the chunk size a bit, because I noticed that even tests on Ubuntu can randomly fail (max_cpu). Re-running jobs works though.

k4nar commented 4 years ago

Let's try with this :) .