circus-tent / circus

A Process & Socket Manager built with zmq
http://circus.readthedocs.org/
Other
1.55k stars 258 forks source link

DevOps: Adopt PEP 621 and use `pyproject.toml` #1197

Closed sphuber closed 2 years ago

sphuber commented 2 years ago

Fixes #1196

PEP 621 introduces the pyproject.toml file which is now the recommended way for defining a project with its build and install dependencies. In addition, it allows to provide configuration for various tools, such as tox, instead of using individual files for each tool.

The MANIFEST.in file is no longer required since the build backend flit will automatically include all files, except those explicitly marked with [tool.flit.sdist] exclude.

The description is added to the __init__.py of the package and it is marked as dynamic in the pyproject.toml which will automatically fetch it from the package docstring.

sphuber commented 2 years ago

Thanks for the review @biozz . Didn't think there was anyone still active on this package as it had gone unmaintained for multiple months. Glad to know that is not the case so I can some feedback :+1: Not planning to do a lot of development, but for now just doing the necessary maintenance to keep it going

biozz commented 2 years ago

No problem! This one is nice and simple, as long as it builds and doesn't add too much trouble when deploying to pypi.

Yeah, I didn't have any problems running circus for the past two years, so I am not motivated enough to actively maintain it. Just tag me next time if you need a review, otherwise I am checking my github notifications once in two-three days.