Closed cgarciaarano closed 8 years ago
Hi, @k4nar,
I'm having the same issue with version 0.12.1
.
Any time frame for the fix?
Thank you, Yarden
@scottkmaxwell : Can I assign you to this one ?
I can pull request my proposal, but I'm not really sure it's correct, it could have side effects.
We are already splitting the args at some point, so I think that self._fix_socket_name
should be applied at this point.
Yeah, it sounds like I was expecting args to already be a list at this point. I am completely swamped at the moment but I can try to have a look toward the end of the week if somebody hasn't figured out a proper fix yet.
@scottkmaxwell any update here?
Sorry this took so long.
@k4nar when can we expect a release containing this fix?
@ayashjorden : Sorry for the delay, I'll try to make a new release this week.
Thank you @k4nar :)
Hey all, has the fix been released yet?
Sorry, I've been experiencing some troubles with our tests suite (cf #984 for progress), and I would really like to fix that before releasing a new version. I'll push as much effort as I can to make it happen this week.
I've merged #984. I'm giving some time to the opened PRs to be rebased & merged, and I'll release a new version.
Thank you for the update, looking forward to it :)
On Tue, Jul 5, 2016 at 2:13 PM, Yannick PÉROUX notifications@github.com wrote:
I've merged #984 https://github.com/circus-tent/circus/pull/984. I'm giving some time to the opened PRs to be rebased & merged, and I'll release a new version.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/circus-tent/circus/issues/930#issuecomment-230451099, or mute the thread https://github.com/notifications/unsubscribe/AEAnU2IKjlNl0Rdss-09wEQlogZ5ltM8ks5qSjxQgaJpZM4F-l60 .
@ayashjorden : I just released Circus 0.14. Sorry for the (very) long delay!
Thank you! @k4nar
Hi,
we've found that Circus 0.12.2 is not parsing args correctly when
use_papa = True
. With this config file:The debug log shows:
and the process keeps flapping.
Commenting out in
papa_process_proxy.py
theself.args
assign:seems to fix this behaviour, because args is being processed as a string, not a list. I'm not really sure what
_fix_socket_name()
is doing. Maybe this fix is enough?Regards