ciren / cilib

Typesafe, purely functional Computational Intelligence
https://cilib.net
Apache License 2.0
124 stars 101 forks source link

Lens fixes and testing Fit cases #291

Closed gpampara closed 6 years ago

gpampara commented 6 years ago

This PR corrects the invalid usage of some of the lenses, whereby data could be changes in ways that would be regarded as "suspect".

Additionally, the Fit data structure now has all it's cases fully tested as property tests, necessitating a small refactor. Unfortunately, I realised a little too late that I was on the wrong branch, so the fitness changes are on the same branch as the lens updates 😞

filinep commented 6 years ago

Sorry, I approved the wrong PR, was supposed to be for #290

filinep commented 6 years ago

Please let me know when I can review this one

gpampara commented 6 years ago

@filinep sorry about that - good to go now

gpampara commented 6 years ago

Haven't forgotten about the fitness issues raised regarding the Multiple case. These will be addressed in a separate PR - still identifying commonalities between multi-swarm and MOO based algorithms.