Possible bug with newest version 2.1.0.0, MIDS volume?

ciribob / DCS-SimpleRadioStandalone

An open source Stand alone Radio for DCS integrating with all clickable cockpits and FC3 Aircraft

GNU General Public License v3.0

471 stars 123 forks source link

Possible bug with newest version 2.1.0.0, MIDS volume? #689

Closed Joghurt closed 10 months ago

Joghurt commented 10 months ago

There's this line in the diff https://github.com/ciribob/DCS-SimpleRadioStandalone/compare/2.0.9.1..2.1.0.0 coming from DCS-SR-Client/Audio/Providers/ClientAudioProvider.cs that says "vol = vol / 0.30f;". I haven't tested it yet, but it seems mathematically wrong to "lower the volume by 30%" as stated in the comment - maybe you want to do something like "vol = vol * 0.70f;"?

ciribob commented 10 months ago

Comment is wrong (rather than the code) but it's supposed to lower the cockpit ambient effects but it's wrong anyway as that lowered all the volume, not the ambient cockpit one

I'll have a look, thanks!

ciribob commented 10 months ago

Tested and fixed - thanks!

Joghurt commented 10 months ago

Thank you for all your work!