Open yashton opened 5 years ago
This is related to #15
14 days ago gabrie-allaigre pushed the sonar-gitlab-plugin-4.1.0-SNAPSHOT pre release from the sonar-gitlab-plugin. It solves -- partially -- the incompatibility with the SonarQube v7.7.
But you can't use the SONAR_ANALYSIS_MODE: "issues" and "preview" anymore, just the "publish". (Please fix me if I'm wrong.)
So simply just avoid to using that deprecated analysis modes, and everything will work. :)
If we can't differentiate the issues and publish mode (as there's only "publish" mode now), how is code gonna be directly commented in gitlab? AFAIK the preview/issues mode is the one who publish to gitlab, whilst the publish mode is the one which really publishes the results to sonarqube.
As far as I can remember, we already tried this before publishing 3.0.0 (under sonarqube 6.7, which started showing the deprecation warnings), and we decided not to remove the option, because there was no way to use the "preview" mode, hence not publishing anything to gitlab itself.
This, and the fact that sonarqube 7 is the first version which differentiates the enterprise edition with the self-hosted/developer one, forced us to stay in Sonarqube 6.
So.. I can't remove the option for the people who's still using Sonarqube. I think we'll need to create a different branch here for Sonarqube 7...
Maybe better... not define anything by default. Doing it this way, people using the option will still be able to use it if they're using Sonarqube 6, and Sonarqube 7 users will be able to ignore it.
Edit: Sorry, closed issue by mistake.
Sonar 7.7 does not support sonar.analysis.mode
https://github.com/gabrie-allaigre/sonar-gitlab-plugin/issues/132 A 7.7 compatibility patch is currently PR https://github.com/gabrie-allaigre/sonar-gitlab-plugin/pull/226