ciricihq / gitlab-sonar-scanner

This project is no longer maintained
GNU General Public License v3.0
80 stars 62 forks source link

When token is used? #8

Closed phouverneyuff closed 7 years ago

phouverneyuff commented 7 years ago

Take a look the code bellow in sonar-scanner-run.sh:

#!/bin/sh

URL=$SONAR_URL
SONAR_TOKEN=$SONAR_TOKEN

if [ -z "$SONAR_PROJECT_KEY" ]; then
  echo "Undefined \"projectKey\"" && exit 1
else
  COMMAND="sonar-scanner -Dsonar.host.url=\"$URL\" -Dsonar.projectKey=\"$SONAR_PROJECT_KEY\""
....

I can't see SONAR_TOKEN being used. Can I login in my private sonar using token and put the report inside it?

gtrias commented 7 years ago

Thanks for the pull request. We have the permission for anyone to execute analysis since we're hosting our sonar server in internal network. So we aren't using SONAR_TOKEN. Can you confirm if now is working for you and close the issue?

phouverneyuff commented 7 years ago

I'll test

phouverneyuff commented 7 years ago

Worked! Thanks for accept!

elboletaire commented 7 years ago

You're welcome 😃