cirocosta / slirunner

Concourse SLI probes runner
6 stars 4 forks source link

password having reserved character for shell does not work #8

Open howardyoo opened 3 years ago

howardyoo commented 3 years ago

when running slirunner, if, for example, you have a ')' character in your password, it results in error that may look something like this: COMMAND FAILURE--- /bin/bash: -c: line 2: syntax error near unexpected token)' /bin/bash: -c: line 2: fly -t main login -u test -p te)st -c http://concourse:8080' notice the password 'te)st' that is causing the syntax error for the underlying bash script to execute the fly command. The proper fix should be the code would enclose the password with " or ' such that it would look something like:

fly -t main login -u test -p 'te)st' -c http://concourse:8080

That may avoid this error from happening.