[macOS] Kindle Comic Converter has the version number 0.0.0

[core-code]

starting with version 5.6.3 and including version 5.6.4 the Kindle Comic Converter claims to have version "0.0.0"

previous versions up to 5.6.2 did not have this problem, so this is a regression. starting with 5.6.3, the in your Info.plist file the CFBundleVersion was removed (which is a clear bug and should never happen) and the CFBundleShortVersionString was set to "0.0.0" (which is just nonsense)

screenshots from the Finder's GetInfo, ColumnView and QuickLook:

[core-code]

[darodi]

@axu2

might be related to 1318b9c0

Info.plist was removed and version change from setup.py

[axu2]

Yes, I removed our info.plist since it caused tons of issues. pyinstaller provided defaults values like 0.0.0. Copying files after the fact manually into a .app causes tons of issues.

[core-code]

The proper fix will probably involve modifying the pyinstaller command.

since the app is unsigned you could also process the Info.plist after the build step e.g. using /usr/libexec/PlistBuddy

[axu2]

since the app is unsigned you could also process the Info.plist after the build step e.g. using /usr/libexec/PlistBuddy

Changing the version number after building results in the original damaged error.

• related #566

The proper way to do this is to switch from building directly from the .py to adding the intermediate .spec step.

• https://github.com/pyinstaller/pyinstaller/issues/6943

[darodi]

@axu2

Also the plist said 5.5.2 which hasn't been updated in a while. Current at the time was 5.6.2 Originally posted by @axu2 in https://github.com/ciromattia/kcc/issues/632#issuecomment-1832555911

version was replaced at build time with this code before https://github.com/ciromattia/kcc/commit/1318b9c0f2a86ed26b461bb9eab125f2687d7ff9.

https://github.com/ciromattia/kcc/blob/d8957dc4a6ef2941cad6ee1d523a55a5a204c3b1/setup.py#L43-L47

[core-code]

still not fixed in 6.2.0, it still claims to be 0.0.0