search

cirosantilli / parsec-benchmark

PARSEC Benchmark http://parsec.cs.princeton.edu 3.0-beta-20150206 ported to Ubuntu 22.04 and with proper version control and SPLASH2 ported to Buildroot 2017.08 cross compilation (ARM, MIPS, etc.). This repo intends to support all build types and benchmarks. Test data stored on a release since the Princeton website died.
Other
80 stars 39 forks source link

uptcpip has wrong alias #19

Open voltavidTony opened 2 weeks ago

voltavidTony commented 2 weeks ago

This is more of a nitpick as it doesn't seem to affect anything. I was looking at the info output and config files and noticed that config/packages/parsec.uptcpip.pkgconf incorrectly assigns the alias netapps to uptcpip, even though it is a utility library located in a libs folder.

cirosantilli commented 2 weeks ago

This happens in a few other places too it seems:

config/packages/parsec.netdedup.pkgconf:20:pkg_group="netapps"
config/packages/parsec.netdedup.pkgconf:23:pkg_aliases="all workload parsec netapps pthreads"
config/packages/parsec.netferret.pkgconf:20:pkg_group="netapps"
config/packages/parsec.netferret.pkgconf:23:pkg_aliases="all workload parsec netapps pthreads"
config/packages/parsec.netstreamcluster.pkgconf:20:pkg_group="netapps"
config/packages/parsec.netstreamcluster.pkgconf:23:pkg_aliases="all workload parsec netapps pthreads tbb"
config/packages/parsec.uptcpip.pkgconf:23:pkg_aliases="all libs netapps"

What is the effect of aliases if any?

voltavidTony commented 2 weeks ago

Aliases are simply a way to group some packages together. For instance, doing ./parsecmgmt -a run -p netapps will execute netdedup, netferret, and netstreamcluster. uptcpip is correctly excluded from the list, so I think assigning uptcpip to the alias netapps was a mistake that went unnoticed since it did not produce any incorrect behavior. There are also other aliases such as parsec, splash2xapps, workoad, openmp, etc. They can be thought of as other package groups that the package is also a member of

cirosantilli commented 2 weeks ago

OK. Hmm, I think let's just leave it if it isn't breaking anything, I'm afraid of accidentally breaking something else. Not the most idealistic approach, but I don't use this repo often and a bug could remain unnoticed for a long time.