Lack of entry_pt pthread_create return value causes segfault in parsec.canneal

cirosantilli / parsec-benchmark

PARSEC Benchmark http://parsec.cs.princeton.edu 3.0-beta-20150206 ported to Ubuntu 22.04 and with proper version control and SPLASH2 ported to Buildroot 2017.08 cross compilation (ARM, MIPS, etc.). This repo intends to support all build types and benchmarks. Test data stored on a release since the Princeton website died.

Other

83 stars 39 forks source link

Lack of entry_pt pthread_create return value causes segfault in parsec.canneal #5

Closed jic23 closed 4 years ago

jic23 commented 4 years ago

https://github.com/cirosantilli/parsec-benchmark/blob/1d4a1025e06a4f7ad23f1ca7f908e0135e712585/pkgs/kernels/canneal/src/main.cpp#L137

The dumb approach of returning NULL from this function seems to solve the segfault. I haven't done any sanity checking on whether this is the 'right' fix or not.

cirosantilli commented 4 years ago

OMG how can a benchmark be so broken.

jic23 commented 4 years ago

It did rather surprise me. Thanks for your hard work on sorting these out btw. I was doing pretty much the same thing and got most of the way through making the same changes you did and then came across your repo! Guess I should have done some more googling.

cirosantilli commented 4 years ago

Guess I should have done some more googling.

The story of my life! If you find any other fixes, let me know.