cirospaciari / socketify.py

Bringing Http/Https and WebSockets High Performance servers for PyPy3 and Python3
https://www.socketify.dev
MIT License
1.37k stars 47 forks source link

If response has a header, written status code is ignored #144

Open Aksem opened 10 months ago

Aksem commented 10 months ago

Describe the bug If at least one header is written in response and then status code, e.g. 404, then provided status code is ignored and is always 200. Without header, status code is correct.

To Reproduce Steps to reproduce the behavior:

  1. Start socketify app with following implementation:
    
    from socketify import App

def handler(response, req): response.write_header( "Access-Control-Allow-Origin", "*" ) response.write_status(404) response.end("Not found")

app = App() app.any("/*", handler) app.listen(3000, lambda config: print("Listening on port http://localhost:%d now\n" % config.port)) app.run()


2. Send any request to localhost:3000
3. Check status code, it is 200 instead of expected 404.

**Expected behavior**
Status code 404.

**Desktop (please complete the following information):**
 - OS: Linux

**Additional context**
Without `response.write_header` call, status code is 404 as expected.
cirospaciari commented 1 month ago

Right now the solution is call write_status first, this is a uWS thing https://github.com/cirospaciari/uWebSockets/blob/d5ec941fd8d29f3df6afbc73164d3c8bf0f49079/src/Http3Response.h#L33-L41 will change this in the future