search

cirospaciari / socketify.py

Bringing Http/Https and WebSockets High Performance servers for PyPy3 and Python3
https://www.socketify.dev
MIT License
1.37k stars 47 forks source link

Response.resume() does not work #146

Open mikesway opened 9 months ago

mikesway commented 9 months ago

Describe the bug The resume() method does not work on Response although pause() does. I traced this down to the uWebSockets uws_res_resume() API calling uwsRes->pause() instead of uwsRes->resume(). There was a bug filed there and just fixed: https://github.com/uNetworking/uWebSockets/issues/1686

To Reproduce I reproduced by uploading a large file to a route. I was able to pause it correctly with pause() but I could never get it to resume with resume(). It would always just remain stuck.

I actually patched and rebuilt the uWebSocket .so libraries with the fix locally and it seems to work well.

Expected behavior The resume() should continue the upload after pausing.

cirospaciari commented 9 months ago

Oh I will push this fix and other fixes this week end, thanks for reporting!

mikesway commented 8 months ago

It's been a couple weeks, any progress here? Is there something I can do to help?