search

cirquit / trdrop

trdrop - a raw video analysis program
MIT License
381 stars 33 forks source link

Custom frametime limit is ignored #137

Open flibberdipper opened 2 years ago

flibberdipper commented 2 years ago

Just started trying to use this and noticed that it outright ignores the custom value I set for the frametime graph. I have it set to 90, but as soon as it goes beyond that it automatically adjusts the graph to whatever the highest spike was.

EDIT: Also noticed the sidebar option to modify further frametime settings is grayed out, so maybe I'm just jumping the gun and this feature still isn't fully complete?

illusion0001 commented 2 years ago

Please try #139

Rossa-GH commented 2 years ago

Was messing around with trdrop a while ago and noticed this to be an issue.

Did a quick test with that new build and it seems to fix it. Only bit of weirdness is the line can now go out of the limits of the graph (see example below).

I know that the alternative is putting a hard cap on the line and you then don't see the true nature of the spike, but it would make things look cleaner though.

Untitled_2 1 1

illusion0001 commented 2 years ago

Yea it's a double edge sword situation.

Rossa-GH commented 2 years ago

Yeah, it definitely is. Personally I'd prefer the hard limit, but that's just me.

Ideally there'd probably be a UI toggle between the OG version and this, but with hard limit applied to the line.

You guys are focused on v2 though, so I know adding features like that is probably not worth the time at this point. Either way, it's a good update, thanks.

Rossa-GH commented 2 years ago

Also, I feel like it's worth mentioning that the changes this problem causes are not permanent. The graph eventually reverts to the original max value, but it waits for the spike to be long gone. (Example below)

Maybe a quicker way to mitigate this issue would be to make the graph revert to the original max value the second the spike leaves the graph?

These 2 screenshots are exactly 20 second apart. Analysis range is 30 frames.

Untitled_2 1 1 Untitled_2 1 2