search

cirquit / trdrop

trdrop - a raw video analysis program
MIT License
381 stars 33 forks source link

Cannot choose more than 180 frames analysis range #96

Closed aj752 closed 2 years ago

aj752 commented 3 years ago

Hi,

Hopefully I'm not just doing something wrong, I read that some issues were fixed to allow an higher value than 180 frames for the range of frames per seconds and frame time. I'm using v1.1.1 but whenever I input a higher number it automatically jumps back to 180. Is there a way to increase beyond 180 or is it a feature which will be added in the future?

Thanks in advance.

cirquit commented 3 years ago

There's a limit set to the framerate analysis time from 30 to 180FPS (https://github.com/cirquit/trdrop/blob/master/trdrop/qml/OptionsWindow.qml#L153). What you're referring to is the maximum framerate setting where it won't scale the plot if we drop below a certain FPS.

I kind of remember trying to increase the number of processed frames and it started a little bit of lagging for me. I have to double-check that again as I'm not 100% sure if this was when I tested that, but in reality, it shouldn't be much of an issue.

The modules touched by that change are, as you said yourself, the framerate and the frame time calculation. For those, I keep a queue with that exact length (180) and just add new items to the front, and remove the old information from the back so we keep a nice container with the most up-to-date data. It shouldn't have much of an effect on performance or memory.

I'll try to see what I can do. What kind of values were you looking for? I thought 3 minutes should be typically enough of a resolution.

aj752 commented 3 years ago

Thank you for the reply. So 180 frames equals 3 seconds with a 60FPS video, this is for me personally fine - although I would love to see higher. With 120FPS videos is halfs down to 1,5 seconds and it is really short, you feel like it is flying by. I would personally suggest a value of max like 720. Up to 12 seconds with 60FPS or 6 seconds with 120FPS videos.

illusion0001 commented 3 years ago

@masterant86 Please test build in #97

aj752 commented 3 years ago

Is this really happening 😃

unable to test right away but will do within the next 48 hours, very excited to try it out!

aj752 commented 3 years ago

I appologize, I wasn't able to react/test earlier like mentioned. I'm about to test right now with a few just recorded 120FPS clips. Is there something I need to be looking for or just use it like I normally would but than increase the range?

aj752 commented 3 years ago

@masterant86 Please test build in #97

I tested un multiple videos, everything seems to be working perfect. All the defaults are the ones I choose so this will be my build going forward! Because the graphs are the same size, it also doesn't affect my Effects to transform the graphs to something else - which I was a bit worried about. Amazing work!

illusion0001 commented 3 years ago

Thanks for testing :)