search

cirros-dev / cirros

120 stars 33 forks source link

Add injection for /etc/os-release #94

Closed NucciTheBoss closed 2 years ago

NucciTheBoss commented 2 years ago

Same as #85, but without the borked rebase :sweat_smile:. Learned my lesson.

Adds an injection for /etc/os-release and updates the cirros_version() function.

Closes #79

NucciTheBoss commented 2 years ago

@hrw this is the updated pull request for the injection with the changes squashed. I tried to rebase but messed it up, so I decided to just open a new pull request with changes. Thanks!

NucciTheBoss commented 2 years ago

Added a new commit to change http:// to https:// and squashed it into the earlier commit. Should be good to merge.

osfrickler commented 2 years ago

The resulting os-release file looks fine to me, however there is an useless /etc/cirros/.gitkeep file left over, maybe you can remove that, too? Otherwise I'd do that in a followup.

smoser commented 2 years ago

The resulting os-release file looks fine to me, however there is an useless /etc/cirros/.gitkeep file left over, maybe you can remove that, too? Otherwise I'd do that in a followup.

I guess i agree with this. but this can be done in follow up or here. either way. thanks.