cirrusidentity / simplesamlphp-module-cirrusgeneral

Various simplesamlphp filters and utilities.
GNU Lesser General Public License v2.1
2 stars 1 forks source link

Typed properties force PHP 7.4+ #11

Open dnmvisser opened 2 years ago

dnmvisser commented 2 years ago

I noticed that the code uses typed properties which were only introduced in PHP 7.4. Unfortunately our SimpleSAMLphp instance is still at 7.3.9... I was able to get it to work by removing the type hints: https://github.com/GEANT/simplesamlphp-module-cirrusgeneral/pull/1/files Would it be worth having a tag/release here for the people that are not yet on 7.4+?

many thx