cirruslabs / cirrus-ci-agent

Agent to execute Cirrus CI tasks
Mozilla Public License 2.0
13 stars 6 forks source link

Relativize absolute symlinks only if they are within working directory #315

Closed fkorotkov closed 1 year ago

fkorotkov commented 1 year ago

Reported to support that Python venv is creating a symplink to /usr/bin/python3 which is not stored correctly.

As I remember the relativization was added since working directlory can change based on an instance. For example, persisten workers use a ramdom one in /tmp for each task. IMO it makes sense to only leave the tricky logic if a symlink is within base.