feat(vault): add support for arguments

cirruslabs / cirrus-ci-agent

Agent to execute Cirrus CI tasks

Mozilla Public License 2.0

13 stars 6 forks source link

Closed malena-ebert-sonarsource closed 11 months ago

malena-ebert-sonarsource commented 11 months ago

This PR is adding support to set arguments for fetching credentials.

Some enabled use cases are the following:

adjust the TTL of AWS credentials
- https://developer.hashicorp.com/vault/api-docs/secret/aws#ttl
- VAULT[path/aws/sts/role-name access_key ttl=900]
select the secret version of a KV entry
- https://developer.hashicorp.com/vault/api-docs/secret/kv/kv-v2#version
- VAULT[path/kv/data/entry data.foo version=2]

To get a cached value, the arguments must be equal.

malena-ebert-sonarsource commented 11 months ago

Hello Malena 👋 Thanks for the contribution!

LGTM overall, l've left a couple nits related to the error messages.

I updated the PR with your suggestions.