search

cirruslabs / cirrus-ci-agent

Agent to execute Cirrus CI tasks
Mozilla Public License 2.0
13 stars 6 forks source link

Use a separate pre-expanded environment for Vault-unboxing process #333

Closed edigaryev closed 9 months ago

edigaryev commented 9 months ago

This achieves the same thing as https://github.com/cirruslabs/cirrus-ci-agent/pull/330, but without delaying the environment variable expansion step that might resolve the variables critical for the Vault client initialization (e.g. CIRRUS_VAULT_URL).

Will mark as ready to review once I'll come up with an appropriate test for this.

edigaryev commented 9 months ago

Had to introduce CIRRUS_VAULT_TOKEN environment variable for the added test (TestVaultSpecificVariableExpansion).

Perhaps it could be useful as an alternative method of authentication to OIDC.