Don't hide cancellation reason

cirruslabs / cirrus-ci-agent

Agent to execute Cirrus CI tasks

Mozilla Public License 2.0

13 stars 6 forks source link

Don't hide cancellation reason #363

Closed fkorotkov closed 5 months ago

fkorotkov commented 5 months ago

Otherwise, we assume a task has timeout when in reality it could've been externally interrupted.

fkorotkov commented 5 months ago

I'll cherry pick changes to the new CLI after this change is merged.

edigaryev commented 5 months ago

What do you think about also printing the value of response.TimeoutInSeconds and/or timeoutCtx.Deadline() to the agent's log?

This should provide some additional clues.

fkorotkov commented 5 months ago

Don't think the issue is with TimeoutInSeconds since we saw "Capruted terminated..." log message. "Timed out!" message is just misleading in that case.