search

cirruslabs / gitlab-tart-executor

GitLab Runner executor to run jobs in Tart VMs
MIT License
60 stars 5 forks source link

TART_EXECUTOR_INSTALL_GITLAB_RUNNER: deprecate "true" #55

Closed edigaryev closed 10 months ago

edigaryev commented 10 months ago

In favor of explicit "brew" and "curl" installation methods.

Tested all combinations manually on ghcr.io/cirruslabs/macos-sonoma-base:latest.

Resolves https://github.com/cirruslabs/gitlab-tart-executor/issues/48.

fkorotkov commented 10 months ago

What do you think of host option in the future? https://github.com/cirruslabs/gitlab-tart-executor/issues/48#issuecomment-1888642685

edigaryev commented 10 months ago

What do you think of host option in the future? #48 (comment)

From the linked issue:

for the specific versions, tart would pick an appropriate installation method (though for simplicity's sake, i would just go for curl)

I think we should only implement host if separate brew and curl wouldn't cut it.

fkorotkov commented 10 months ago

At the same time @cosmoshepcat reported that curl was flaky one day. Having a local copy transferred will make sure the config step is more stable.

We can start with this option to have an ability to choose strategy. But 'host' looks like an ideal solution for making sure runner on the host and writhing a VM is identical. 🤷‍♂️

umlaeute commented 10 months ago

how does this solve #48 ? the title of my issue was "force a given version of gitlab-runner?" which i do not see addressed at all.