Don't run rbenv'd gem commands with sudo

cirruslabs / macos-image-templates

MIT License

207 stars 56 forks source link

Don't run rbenv'd gem commands with sudo #135

Closed anders-nylander closed 6 months ago

anders-nylander commented 6 months ago

Should fix #134

fkorotkov commented 6 months ago

Thank you for highlighting the issue! Do you think it's a backward compatible change? I think some users might find this out and use sudo in their scripts already.

anders-nylander commented 6 months ago

I believe it should be a fully backward compatible change. .rbenv is meant to be user-owned, though sudo-ing your commands at any point after this should still work (even if it's not the best idea), as demonstrated by how things work today.