cirruslabs / macos-image-templates

MIT License
207 stars 56 forks source link

Clarify policy on Flutter version #142

Closed bartekpacia closed 4 months ago

bartekpacia commented 5 months ago

Installing Flutter takes some time, so I think it's good to explicitly specify what "comes with Flutter pre-installed" means. Developers might use this image and realize they need to install a different Flutter, and the CI times go up a bit (or they create a custom 50-something-GB VM image)

I also did some minor formatting changes, it's so minor that I didn't bother spitting into 2 PRs. I hope it's okay.

fkorotkov commented 5 months ago

Images have the latest Flutter version of the moment when images are built. Switching channels or pulling updates should be still faster then reinstalling things from scratch.

bartekpacia commented 5 months ago

Images have the latest Flutter version of the moment when images are built.

OK, so I'll update this README to reflect this. I just want the README to reflect the policy, not try to change existing.

Switching channels or pulling updates should be still faster then reinstalling things from scratch.

Switching Flutter channel clone a Flutter repo, Dart SDK, and then (if you run flutter precache) also downloads artifacts. So installing Flutter from scratch is basically the same as changing channel or upgrading Flutter.

bartekpacia commented 5 months ago

Images have the latest Flutter version of the moment when images are built.

But when are the images built? Looks like it happens on every commit to the master branch, but I'd say the original cause is usually:

Should a new PATCH Flutter version be added to this list? In a similar way as docker-images-flutter checks for it.