cirruslabs / orchard

Orchestrator for running Tart Virtual Machines on a cluster of Apple Silicon devices
Other
192 stars 15 forks source link

Switch from golang.org/x/net/websocket to nhooyr.io/websocket and handle NotFound errors #105

Closed edigaryev closed 1 year ago

edigaryev commented 1 year ago

golang.org/x/net/websocket hides the underlying HTTP error when upgrading the WebSocket connection nor provides a *http.Response for the consumer to craft their own error and overall seems to be deprecated: https://github.com/golang/go/issues/33215, https://github.com/golang/go/issues/18152.

Resolves https://github.com/cirruslabs/orchard/issues/97.