search

cirruslabs / orchard

Orchestrator for running Tart Virtual Machines on a cluster of Apple Silicon devices
Other
189 stars 13 forks source link

Set HTTP client timeout to 30 seconds #153

Closed edigaryev closed 5 months ago

edigaryev commented 5 months ago

There's no timeout by default, which may result Orchard CLI or Worker hanging waiting for request to complete.

See https://github.com/cirruslabs/orchard/issues/152.

fkorotkov commented 5 months ago

Could you please be a bit more descriptive about why it fixed the mentioned issue?

edigaryev commented 5 months ago

Could you please be a bit more descriptive about why it fixed the mentioned issue?

See https://github.com/cirruslabs/orchard/issues/152#issuecomment-1927091747.

fkorotkov commented 5 months ago

Cool. Let's still have some description with a reference to the comment with the investigation.

edigaryev commented 5 months ago

Cool. Let's still have some description with a reference to the comment with the investigation.

See https://github.com/cirruslabs/orchard/pull/153/commits/fc4d4a90cc3cc6e5f73bca049ce5127f704d669b.

fkorotkov commented 5 months ago

Thank you!