search

cirruslabs / orchard

Orchestrator for running Tart Virtual Machines on a cluster of Apple Silicon devices
Other
189 stars 13 forks source link

Randomize the VM's MAC-address when using bridged networking #182

Closed edigaryev closed 1 month ago

edigaryev commented 1 month ago

Since DHCP shortage is not an issue when using --net-bridged, we can safely do that while avoiding the potential collisions in the LAN.

Resolves https://github.com/cirruslabs/orchard/issues/181.

fkorotkov commented 1 month ago

Tart do check if there is a VM with the same MAC:

https://github.com/cirruslabs/tart/blob/bf5081b3d9564e456dc1bead73b7e2b3a5939dc5/Sources/tart/Commands/Run.swift#L198-L206

Is here a race? Or it's the case when multiple hosts connected to the same LAN and our Tart check is only per-host?

edigaryev commented 1 month ago

Or it's the case when multiple hosts connected to the same LAN and our Tart check is only per-host?

Exactly.