search

cirruslabs / packer-plugin-tart

Packer builder for Tart VMs
https://developer.hashicorp.com/packer/plugins/builders/tart
Mozilla Public License 2.0
65 stars 17 forks source link

Stream Tart stdout/stderr output to Packer UI #124

Closed torarnv closed 7 months ago

torarnv commented 8 months ago

Creating a Tart VM may involve long running operations such as downloading an IPSW, or installing the OS. Tart gives us progress during these operations, so let's forward it to the Packer UI, the same way the shell-local provisioner does.

If a packer.Ui is not provided, we keep the previous code path that returns the output to the caller, for example used by the TartMachineIP helper.

torarnv commented 8 months ago
image
torarnv commented 7 months ago

Cheers @fkorotkov ! Do I need to do something to merge this? Should we wait for @edigaryev ?

fkorotkov commented 7 months ago

@edigaryev is coming back from PTO tomorrow so I guess let's wait for him if you don't mind.

torarnv commented 7 months ago

No problem from my side. I have some more changes lined up, so the only thing is that it's a bit of a pain to juggle the changes into individual PRs on the GitHub side, but I can manage :D