search

cirruslabs / tart

macOS and Linux VMs on Apple Silicon to use in CI and other automations
https://tart.run
Other
3.8k stars 112 forks source link

Restore behavior of --vnc and --vnc-experimental to disable default UI #758

Closed torarnv closed 6 months ago

torarnv commented 6 months ago

Otherwise we end up with two UI windows with --vnc or --vnc-experimental, one for the built in UI and one for the Screen Sharing connection.

Disabling the built in UI window via --no-graphics in this situation is not ideal, as it also disables the convenience of Tart automatically opening Screen Sharing with the right address and password.

Restoring the behavior allows the choice of headless or not via --no-graphcis to be made independently of how the UI is provided, either via the default UI, or via Screen Sharing / VNC.

The --graphics option is still deprecated, to keep the command line options from running wild.

See #732

fkorotkov commented 6 months ago

Should we just revert #732 but keep --graphics hidden to not confuse tart run --help. --graphics is only used for supervising Packer's boot commands. What do you all think? /cc @edigaryev

edigaryev commented 6 months ago

Should we just revert #732 but keep --graphics hidden to not confuse tart run --help. --graphics is only used for supervising Packer's boot commands. What do you all think? /cc @edigaryev

SGTM.

torarnv commented 6 months ago

Works for me 😊 thanks!

fkorotkov commented 6 months ago

Closing in favor of #763