Adding Allison Horst's Artwork (finally!)

cis-ds / course-site

Course site for Computing for Information Science (INFO 5940)

43 stars 41 forks source link

Adding Allison Horst's Artwork (finally!) #285

Closed deblnia closed 3 years ago

deblnia commented 3 years ago

I've added Allison Horst's artwork in the places it seemed most strictly relevant (mostly dplyr functions and the new tidymodels material). I've also added citations as alt text (can definitely change to be explicit if you prefer). There are also a few unused but course-adjacent images in the folder (the images about patchwork, lubridate, and broom specifically) that I'm still trying to find the best place for (just creating the PR now to make sure this builds). Happy to make any changes as always 😄
Working on #192.

bensoltoff commented 3 years ago

I think the only adjustment that needs to be made is the source credit at the bottom of each page. Otherwise it all looks good. Thanks so much for working on this!

deblnia commented 3 years ago

Added acknowledgements properly I think! I'm having a bit of trouble knitting all the docs though (it's just a bit of dependency hell for some reason), is there any way the deploy can take care of that? (Happy to work through it if no!)

bensoltoff commented 3 years ago

@deblnia Rmd and RMarkdown files could be automatically knitted if I switched to deploying using Travis CI + GitHub. However I am not proficient using Travis, the blogdown authors discourage this approach, and I like the ability to preview locally before I push to GitHub (for minor updates I don't bother creating a separate branch which means these pushes would immediately go live on the website).