Refactor code quality issues

akshgpt7 commented 3 years ago

🗣 Description

Hey :wave:, I'm a Developer Outreach at DeepSource and ran DeepSource analysis on my fork of the repo. It found some interesting code quality improvements to consider.

This PR fixes a few of the issues detected for you to assess if it is right for you. Happy to provide the tweaks separately otherwise :)

Summary of changes

Fix dangerous default arguments.
Remove unnecessary lambda expressions.
Refactor unnecessary else / elif when if block has a return statement.
Remove unnecessary typecast.
Add .deepsource.toml file for continuous analysis on bug risks/performance/code-quality issues on new changes.

💭 Motivation and context

There are certain Anti-Patterns, bug risks and performance issues detected in some files (linked above), that can improve the general code quality here.

✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced in code comments.
[ ] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

akshgpt7 commented 3 years ago

@DeemOnSecurity DeepSource cannot be run as a GitHub action, however, it can run as a GitHub check (checks that run on a PR). The configuration file for a GitHub check has to be present in the root of the repository. Several other CI tools like TravisCI, codecov etc. have their configs in the root itself. Can you let me know your inclination towards having only GitHub actions?

DeemOnSecurity commented 3 years ago

@DeemOnSecurity DeepSource cannot be run as a GitHub action, however, it can run as a GitHub check (checks that run on a PR). The configuration file for a GitHub check has to be present in the root of the repository. Several other CI tools like TravisCI, codecov etc. have their configs in the root itself. Can you let me know your inclination towards having only GitHub actions?

After extensive conversations internally, we have decided not to merge DeepSource into this repository. Thank you for your submission!

cisagov / CHIRP